Add missing for-attribute #6249
Conversation
✅ Deploy Preview for plone-components canceled.
|
Gomez
changed the title
|
@plone/volto-accessibility Needs review |
Gomez
force-pushed
the
improve-checkbox-a11y
branch
from
146e718 to
4936689
Compare
|
The failing changelog check is a lie, and can be ignored. See #6232. The failing tests, however, cannot be ignored and must pass. I restarted them in case it was flaky and temporary. |
packages/volto/src/components/manage/Blocks/Search/components/SearchInput.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@Gomez have a look at my issue https://github.com/plone/volto/pull/6249/files#r1716735124
Gomez
force-pushed
the
improve-checkbox-a11y
branch
from
4936689 to
85f08bc
Compare
|
Thanks @ichim-david! This is a useful comment, i removed the duplication. Changelog updated with @stevepiercy comments. |
There was a problem hiding this comment.
Changelog is good. @ichim-david will review upon his return, or someone else can do a technical review.
Gomez
changed the title
|
@Gomez I'll work on this tomorrow as part of the Salamina sprint. |
There was a problem hiding this comment.
This can be merged now. The fix was good although I had to improve it due to how the checkbox component works
https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/modules/Checkbox/Checkbox.js#L201
By passing the id the label gets the htmlFor from the component without us needing to add it manually
We had an a11y audit, these improvements were noted.